Veterans with cancer face a significantly higher suicide attempt rate, especially in the months after diagnosis. The risk persists for years.